Messages in this thread | | | Subject | Re: [PATCH -mm 1/5] list.h: add list_singleton | From | Peter Zijlstra <> | Date | Mon, 17 Mar 2008 16:13:18 +0100 |
| |
On Mon, 2008-03-17 at 11:04 -0400, Masami Hiramatsu wrote: > Hi Peter, > > Peter Zijlstra wrote: > >>> So I guess we can proceed with your list_singleton(), but I'd just like to > >>> flag this possible confusion, see what people think.. > > > > May I kindly ask to please not use the singleton name like this. It does > > not implement the singleton pattern and will be a great confusion for > > everybody who expects it to. > > Indeed. > > I have some other candidates. > - list_single > - list_has_one > - list_one > > Could you tell me which or some other name you recommend?
I think list_has_one() or list_is_singular() are good names, they convey they are a test for a condition by using a form of be.
| |