lkml.org 
[lkml]   [2008]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/3] KEYS: Make the keyring quotas controllable through /proc/sys
Date
Andrew Morton <akpm@linux-foundation.org> wrote:

> > +#ifdef CONFIG_SYSCTL
> > +extern ctl_table key_sysctls[];
> > +#endif
>
> I've been going around telling people to not bother with the ifdefs here.
> Upside: looks nicer. Downside: defers the build error from compile-time to
> link-time.

Should this extern actually be in include/linux/sysctl.h? I'd rather not put
it in include/linux/key.h as that means that key.h must include sysctl.h just
to get a definition of ctl_table. Conversely, however, sysctl.h doesn't need
to include key.h to include the above extern.

David


\
 
 \ /
  Last update: 2008-03-14 12:49    [W:0.059 / U:19.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site