Messages in this thread | | | Subject | Re: [PATCH v1] change likeliness accounting | From | Daniel Walker <> | Date | Fri, 14 Mar 2008 12:53:31 -0700 |
| |
On Fri, 2008-03-14 at 00:06 +0100, Roel Kluin wrote:
> - seq_printf(out, "|%9u|%9u\t%s()@:%s@%d\n", true, false, > - entry->func, entry->file, entry->line); > + sprint_symbol(function, entry->caller); > + seq_printf(out, "|%9u|%9u\t%s()@:%u\n", pos, neg, function, > + entry->label >> LP_LINE_SHIFT);
Looks like we're missing a "|" after the second %9u above .. You could add that as long as your modifying this area.. Also your tabbing is a little too heavy ..
I wonder if you think the change to saving the caller EIP is better than saving the file name? The size saving in the likeliness struct is nice, but since this is for debugging is not at all required ..
Overall it looks like a nice update/cleanup ..
(CC'd Andrew and Hua..)
Daniel
| |