lkml.org 
[lkml]   [2008]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] at73c213: Fix DMA size at the end of DMA buffer
From
On Fri, 14 Mar 2008 10:44:45 +0100, Haavard Skinnemoen <haavard.skinnemoen@atmel.com> wrote:
> > + size = runtime->period_size * runtime->channels;
> > + if (next_period == runtime->periods - 1)
> > + size += (runtime->buffer_size % runtime->period_size)
> > + * runtime->channels;
>
> Ow. That looks expensive. Isn't there any way we can force the client
> to select sane values of buffer_size and period_size?

Well, I suppose it is not _too_ expensive. :)

> It seems like a reasonable demand that buffer_size is a multiple of
> period_size, doesn't it?

But actually it can happen. And I gave up understanding how are these
parameters determined... If there were any way the driver can enforce
that constraint, it would be better fix.

Iwai-san, any comments from alsa guru?

---
Atsushi Nemoto


\
 
 \ /
  Last update: 2008-03-14 14:31    [W:0.040 / U:2.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site