Messages in this thread | | | From | David Brownell <> | Subject | Re: [UPDATED v3][PATCH 1/7] regulator: consumer interface | Date | Wed, 12 Mar 2008 21:08:48 -0800 |
| |
On Wednesday 12 March 2008, Mark Brown wrote: > On Wed, Mar 12, 2008 at 01:52:46PM -0800, David Brownell wrote: > > On Wednesday 12 March 2008, Mark Brown wrote: > > > > What do you see as being missing in the externally presented interface? > > > It's not *presented* as a tree of power domains, and it's not clear > > that's the intended model. Plus, what Liam said about the names > > being global, not local/logical. > > Hrm. I suspect that the documentation which Liam is currently writing > (together with some actual in-tree users) will help here.
Yes, code is only one part of a balanced architecture. It's pretty weak at conveying any "big picture" issues, especially with only one underlying implementation. If I can't get that picture without reviewing 100+ KBytes of code, then something critical is missing...
I've been pushing for clear explanations in part because, well, nobody else has. I've come across clear needs for basic power switching, to manage sections of both SOCs and boards; and less clear needs for voltage adjustment. I've been hoping some of the other folk who have looked at these issues would chime in.
- Dave
> Right; any regulator API is going to need to cope with connecting > multiple chips together since that's such a core use case.
| |