lkml.org 
[lkml]   [2008]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Mark early_printk as asmlinkage
On 03/12/2008 03:04 PM, H. Peter Anvin wrote:
> Jiri Slaby wrote:
>> It's not explicitly marked as asmlinkage, but invoked from x86_32
>> startup code with parameters on stack.
>>
>> No other architectures define early_printk and none of them are affected
>> by this change, since defines asmlinkage as empty token.
>
> NAK.
>
> The regparm ABI for x86-32 uses parameters on the stack when the
> function is varadic (as it is here), so this is unnecessary.

Makes sense. Why is printk marked as asmlinkage?


\
 
 \ /
  Last update: 2008-03-12 15:09    [W:0.059 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site