Messages in this thread | | | Date | Wed, 12 Mar 2008 15:07:14 +0100 | From | Jiri Slaby <> | Subject | Re: [PATCH] Mark early_printk as asmlinkage |
| |
On 03/12/2008 03:04 PM, H. Peter Anvin wrote: > Jiri Slaby wrote: >> It's not explicitly marked as asmlinkage, but invoked from x86_32 >> startup code with parameters on stack. >> >> No other architectures define early_printk and none of them are affected >> by this change, since defines asmlinkage as empty token. > > NAK. > > The regparm ABI for x86-32 uses parameters on the stack when the > function is varadic (as it is here), so this is unnecessary.
Makes sense. Why is printk marked as asmlinkage?
| |