Messages in this thread Patch in this message | | | Date | Tue, 11 Mar 2008 09:18:15 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] mm: fix alloc_bootmem_core to use fast searching for all nodes |
| |
* Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> [PATCH] mm: fix alloc_bootmem_core to use fast searching for all nodes
a nice improvement as well. Find below the text-inlined patch for -mm inclusion.
Ingo
--------------------> Subject: mm: fix alloc_bootmem_core to use fast searching for all nodes From: "Yinghai Lu" <yhlu.kernel@gmail.com> Date: Mon, 10 Mar 2008 23:23:42 -0700
make the nodes other than node 0 could use bdata->last_success for fast search too.
we need to use __alloc_bootmem_core for vmemmap allocation for other nodes when numa and sparsemem/vmemmap are enabled.
also make fail_block path increase i with incr only needed after ALIGN to avoid extra increase when size is larger than align.
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> Signed-off-by: Ingo Molnar <mingo@elte.hu> --- mm/bootmem.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-)
Index: linux-x86.q/mm/bootmem.c =================================================================== --- linux-x86.q.orig/mm/bootmem.c +++ linux-x86.q/mm/bootmem.c @@ -227,28 +227,32 @@ __alloc_bootmem_core(struct bootmem_data * We try to allocate bootmem pages above 'goal' * first, then we try to allocate lower pages. */ - if (goal && goal >= bdata->node_boot_start && PFN_DOWN(goal) < end_pfn) { - preferred = goal - bdata->node_boot_start; + preferred = 0; + if (goal && PFN_DOWN(goal) < end_pfn) { + if (goal > bdata->node_boot_start) + preferred = goal - bdata->node_boot_start; if (bdata->last_success >= preferred) if (!limit || (limit && limit > bdata->last_success)) preferred = bdata->last_success; - } else - preferred = 0; + } preferred = PFN_DOWN(ALIGN(preferred, align)) + offset; areasize = (size + PAGE_SIZE-1) / PAGE_SIZE; incr = align >> PAGE_SHIFT ? : 1; restart_scan: - for (i = preferred; i < eidx; i += incr) { + for (i = preferred; i < eidx;) { unsigned long j; + i = find_next_zero_bit(bdata->node_bootmem_map, eidx, i); i = ALIGN(i, incr); if (i >= eidx) break; - if (test_bit(i, bdata->node_bootmem_map)) + if (test_bit(i, bdata->node_bootmem_map)) { + i += incr; continue; + } for (j = i + 1; j < i + areasize; ++j) { if (j >= eidx) goto fail_block; @@ -259,6 +263,8 @@ restart_scan: goto found; fail_block: i = ALIGN(j, incr); + if (i == j) + i += incr; } if (preferred > offset) {
| |