lkml.org 
[lkml]   [2008]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: MMC: logical-bitwise and confusion in tifm_sd_transfer_data()?

--- Pierre Ossman <drzeus-mmc@drzeus.cx> wrote:

> On Sun, 09 Mar 2008 21:31:08 +0100
> Roel Kluin <12o3l@tiscali.nl> wrote:
>
> > from drivers/mmc/host/tifm_sd.c:183:
> >
> > if ((r_data->flags & MMC_DATA_WRITE)
> > && DATA_CARRY)
> >
> > shouldn't this be bit-wise &?
>
> First off, I'm not the maintainer of that driver, Alex Dubov is.
>
> Second, the code seems broken, but not in the way you suggest. It should probably have been:
>
> if ((r_data->flags & MMC_DATA_WRITE)
> && (host->cmd_flags & DATA_CARRY))
>

Yes, this is the intended meaning. Can you fix it yourself or should I send a separate patch?



____________________________________________________________________________________
Looking for last minute shopping deals?
Find them fast with Yahoo! Search. http://tools.search.yahoo.com/newsearch/category.php?category=shopping


\
 
 \ /
  Last update: 2008-03-11 08:43    [W:1.047 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site