Messages in this thread | | | Date | Tue, 11 Mar 2008 00:40:54 -0700 (PDT) | From | Alex Dubov <> | Subject | Re: MMC: logical-bitwise and confusion in tifm_sd_transfer_data()? |
| |
--- Pierre Ossman <drzeus-mmc@drzeus.cx> wrote:
> On Sun, 09 Mar 2008 21:31:08 +0100 > Roel Kluin <12o3l@tiscali.nl> wrote: > > > from drivers/mmc/host/tifm_sd.c:183: > > > > if ((r_data->flags & MMC_DATA_WRITE) > > && DATA_CARRY) > > > > shouldn't this be bit-wise &? > > First off, I'm not the maintainer of that driver, Alex Dubov is. > > Second, the code seems broken, but not in the way you suggest. It should probably have been: > > if ((r_data->flags & MMC_DATA_WRITE) > && (host->cmd_flags & DATA_CARRY)) >
Yes, this is the intended meaning. Can you fix it yourself or should I send a separate patch?
____________________________________________________________________________________ Looking for last minute shopping deals? Find them fast with Yahoo! Search. http://tools.search.yahoo.com/newsearch/category.php?category=shopping
| |