lkml.org 
[lkml]   [2008]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.25-rc5-mm1 (paravirt/vsmp/no PCI)
    Ravikiran G Thirumalai wrote:
    > Would anyone have objection to have PARAVIRT depend on PCI, since the
    > vsmp paravirt bits depend on PCI cfg space to determine if the system is
    > vsmp? If not, this patch would suffice.
    >

    NAK. Xen doesn't depend on PCI at all. Why not make VSMP depend on
    PCI? Then you could put something like:

    #ifdef CONFIG_X86_VSMP
    extern void vsmp_init(void);
    extern int is_vsmp_box(void);
    #else
    static inline void vsmp_init(void)
    {
    }

    static inline int is_vsmp_box(void)
    {
    return 0;
    }
    #endif


    in an appropriate header.

    Hm, looks like arch/x86/kernel/Makefile should be

    obj-$(CONFIG_X86_VSMP) += vsmp_64.o


    rather than making it depend directly on CONFIG_PARAVIRT.

    J


    \
     
     \ /
      Last update: 2008-03-12 02:55    [W:0.021 / U:31.744 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site