Messages in this thread Patch in this message | | | Date | Wed, 12 Mar 2008 09:09:33 +0800 | From | Dave Young <> | Subject | [PATCH -mm] do not check condition twice in WARN_ON_SECS |
| |
Don't check condition twice, change WARN_ON(condition) to WARN_ON(1) Thanks Marcin Slusarz <marcin.slusarz@gmail.com> for pointing out
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
--- include/asm-generic/bug.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff -upr linux/include/asm-generic/bug.h linux.new/include/asm-generic/bug.h --- linux/include/asm-generic/bug.h 2008-03-12 08:45:08.000000000 +0800 +++ linux.new/include/asm-generic/bug.h 2008-03-12 09:04:07.000000000 +0800 @@ -80,7 +80,8 @@ extern void warn_on_slowpath(const char int __ret_warn_on = !!(condition); \ if (unlikely(__ret_warn_on)) \ if (__ratelimit(secs * HZ, 1)) \ - WARN_ON(condition); \ + WARN_ON(1); \ + unlikely(__ret_warn_on); \ }) #ifdef CONFIG_SMP
| |