Messages in this thread | | | Date | Tue, 11 Mar 2008 16:46:03 +0300 | From | Pavel Emelyanov <> | Subject | Re: [PATCH] [NFS]: Lock daemon start/stop rework. |
| |
Christoph Hellwig wrote: > On Wed, Jan 30, 2008 at 02:41:34PM +0300, Denis V. Lunev wrote: >> The pid of the locking daemon can be substituted with a task struct >> without a problem. Namely, the value if filled in the context of the lockd >> thread and used in lockd_up/lockd_down. >> >> It is possible to save task struct instead and use it to kill the process. >> The safety of this operation is guaranteed by the RCU, i.e. task can't >> disappear without passing a quiscent state. > > We have a patch series pending on the nfs list that does this plus a lot > more in the area. >
Sorry for bringing it up that late, but I haven't found any patches doing the same for nfs/callback.c. What are the plans about this code? Can we start turning this to kthreads? Or is there some grand rework pending in this code, so that we will just duplicate someone's work or cause unneeded patches conflicts?
You see, this code is the last user of kill_proc(), which in turn is the last user of find_pid() which (in turn) is about to be removed.
Thanks, Pavel
| |