Messages in this thread | | | Date | Mon, 10 Mar 2008 09:23:57 -0300 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH] em28xx-core.c: add missing parentheses in em28xx_write_ac97() |
| |
Roel and Joe,
Thanks for your patches.
I've already received and committed two patches with your proposed changes:
http://linuxtv.org/hg/v4l-dvb/rev/127f67dea087 http://linuxtv.org/hg/v4l-dvb/rev/f83ed13f5bf5
Cheers, Mauro
On Wed, 05 Mar 2008 19:43:46 +0100 Roel Kluin <12o3l@tiscali.nl> wrote:
> Joe Perches wrote: > > >> - if (!((u8) ret) & 0x01) > >> + if (!(((u8) ret) & 0x01)) > > > > I think it'd be clearer without the cast to (u8) > > which is then implicit cast back to int anyway > > > > if (!(ret & 1)) > > ok. > --- > > Signed-off-by: Roel Kluin <12o3l@tiscali.nl> > --- > diff --git a/drivers/media/video/em28xx/em28xx-core.c b/drivers/media/video/em28xx/em28xx-core.c > index 7d1537c..c797472 100644 > --- a/drivers/media/video/em28xx/em28xx-core.c > +++ b/drivers/media/video/em28xx/em28xx-core.c > @@ -267,7 +267,7 @@ static int em28xx_write_ac97(struct em28xx *dev, u8 reg, u8 *val) > for (i = 0; i < 10; i++) { > if ((ret = em28xx_read_reg(dev, AC97BUSY_REG)) < 0) > return ret; > - if (!((u8) ret) & 0x01) > + if (!(ret & 1)) > return 0; > msleep(5); > }
Cheers, Mauro
| |