Messages in this thread | | | From | Roland McGrath <> | Subject | Re: [RFC, PATCH] signals: print_fatal_signal: fix the signr "calculation" | Date | Mon, 10 Mar 2008 19:19:28 -0700 (PDT) |
| |
> For various reasons we can't currently do the same for sig_kernel_coredump() > signals. But, when rlim[RLIMIT_CORE] == 0, we don't actually need coredumping? > So, we could do something like > > > - if (!sig_kernel_coredump(sig)) { > + if (!sig_kernel_coredump(sig) || !signal->rlim[RLIMIT_CORE]) {
I don't like this. I think it's better to leave logic like RLIMIT_CORE checks to the core dump code itself.
Thanks, Roland
| |