lkml.org 
[lkml]   [2008]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] keep rd->online and cpu_online_map in sync
On Mon, Mar 10, 2008 at 04:36:13PM -0700, Andrew Morton wrote:
> > --- a/kernel/sched.c
> > +++ b/kernel/sched.c
> > @@ -5881,7 +5881,8 @@ migration_call(struct notifier_block *nfb, unsigned long action, void *hcpu)
> > spin_unlock_irq(&rq->lock);
> > break;
> >
> > - case CPU_DOWN_PREPARE:
> > + case CPU_DYING:
> > + case CPU_DYING_FROZEN:
> > /* Update our root-domain */
> > rq = cpu_rq(cpu);
> > spin_lock_irqsave(&rq->lock, flags);
>
> Does this make
> cpu-hotplug-register-update_sched_domains-notifier-with-higher-prio.patch
> (below) obsolete,

Yes. I would like to Ack for the
keep-rd-online-and-cpu_online_map-in-sync.patch, as it is more cleaner.


> or do we want both?

No. I don't think so. Gautham, do you agree?

thanks,
suresh

>
> --- a/kernel/sched.c~cpu-hotplug-register-update_sched_domains-notifier-with-higher-prio
> +++ a/kernel/sched.c
> @@ -7096,8 +7096,16 @@ void __init sched_init_smp(void)
> if (cpus_empty(non_isolated_cpus))
> cpu_set(smp_processor_id(), non_isolated_cpus);
> put_online_cpus();
> - /* XXX: Theoretical race here - CPU may be hotplugged now */
> - hotcpu_notifier(update_sched_domains, 0);
> + /*
> + * XXX: Theoretical race here - CPU may be hotplugged now
> + *
> + * We register the notifier with priority 11, which means that
> + * update_sched_domains() will be called just before migration_call().
> + *
> + * This is necessary to ensure that the rt wake up logic works fine
> + * and the rq->rd->online_map remains in sync with the cpu_online_map.
> + */
> + hotcpu_notifier(update_sched_domains, 11);
>
> /* Move init over to a non-isolated CPU */
> if (set_cpus_allowed(current, non_isolated_cpus) < 0)
> _
>


\
 
 \ /
  Last update: 2008-03-11 02:37    [W:0.082 / U:4.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site