Messages in this thread | | | Date | Tue, 11 Mar 2008 00:06:12 +0100 | From | Pavel Machek <> | Subject | Re: PM/FB/gxfb: add config option that allows disabling of VT switch during suspend |
| |
Hi!
> > > > If so, that means extra #ifdef's sprinkled throughout the code. Note > > > > that most framebuffer drivers won't be supporting this, and those that > > > > do will almost certainly always want vt switching turned off.. > > > > > > > > > > I don't think you need any ifdefs or config options at all, do you? Just > > > add a new module parameter to this driver and some little interface into > > > the PM core which allows the driver to set no_vt_switch? > > > > > > > That's a possibility, but doesn't adding hooks into PM core for two > > drivers (lxfb and gxfb) seems like overkill? I also don't really see > > anyone needing to switch back and forth between VT_SWITCH and > > NO_VT_SWITCH other than to work around possible bugs in the register > > save/restore code.. > > I like Andrew's idea. I wager This won't be Geode specific for long. > Either other drivers will get the hint and add real save/restore code > or the GPU subystem code being worked on by the X folks will come along > and make the VT switch obsolete for everybody. Either way, I see hooks > in the PM core as generic love that everybody can benefit from.
Exactly. We'd like _all_ drivers to behave like this. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |