[lkml]   [2008]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] firewire: debug AT, AR, and selfID-complete events
On Sunday 09 March 2008 04:49:34 pm Stefan Richter wrote:
> This adds debug printks for asynchronous transmission and reception and
> for self ID reception. The debug code is per default deactivated by #if
> blocks.
> Signed-off-by: Stefan Richter <>
> ---
> I am undecided whether this is OK for mainline, and whether the debug
> options should become a Kconfig option or runtime options.
> It may be temporarily useful to the few driver developers. Do we want
> end users to provide us with debug logs of this kind? Then it should
> be one or two runtime options.

My vote would be to include this sort of thing with a run-time option to
enable the extra spew, since its a perfectly accepted standard for other
drivers. It ought to be extremely useful in determining whats going wrong
with end-user setups, particularly in cases where we can't reproduce the
problem (typically for lack of having the specific hardware in-house).

Jarod Wilson

 \ /
  Last update: 2008-03-10 05:51    [W:0.047 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site