Messages in this thread Patch in this message |  | | Date | Mon, 10 Mar 2008 16:13:54 +0900 (JST) | Subject | [PATCH] at73c213: Remove redundant private_free routine | From | Atsushi Nemoto <> |
| |
snd_pcm_lib_preallocate_free_for_all() is called from snd_pcm_free() just after calling the private_free routine. So there should be no need to call it in driver's private_free routine.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp> --- diff --git a/sound/spi/at73c213.c b/sound/spi/at73c213.c index 89d6e9c..024db14 100644 --- a/sound/spi/at73c213.c +++ b/sound/spi/at73c213.c @@ -314,15 +314,6 @@ static struct snd_pcm_ops at73c213_playback_ops = { .pointer = snd_at73c213_pcm_pointer, }; -static void snd_at73c213_pcm_free(struct snd_pcm *pcm) -{ - struct snd_at73c213 *chip = snd_pcm_chip(pcm); - if (chip->pcm) { - snd_pcm_lib_preallocate_free_for_all(chip->pcm); - chip->pcm = NULL; - } -} - static int __devinit snd_at73c213_pcm_new(struct snd_at73c213 *chip, int device) { struct snd_pcm *pcm; @@ -333,8 +324,6 @@ static int __devinit snd_at73c213_pcm_new(struct snd_at73c213 *chip, int device) if (retval < 0) goto out; - pcm->private_data = chip; - pcm->private_free = snd_at73c213_pcm_free; pcm->info_flags = SNDRV_PCM_INFO_BLOCK_TRANSFER; strcpy(pcm->name, "at73c213"); chip->pcm = pcm;
|  |