lkml.org 
[lkml]   [2008]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][fs/cifs/cifsfs.c] Make use of cifs_xquota_get
On Mon, Feb 11, 2008 at 06:46:51PM +0100, Roel Kluin wrote:
> Functions cifs_xquota_set and cifs_xquota_get at respectively
> fs/cifs/cifsfs.c:367 and 392 are entirely similar - except for
> whitespace
>
> struct quotactl_ops contains function pointers .set_xquota and
> .get_xquota that both get the address of cifs_xquota_set.
> cifs_xquota_get isn't called anywhere else in the kernel.
>
> The patch below makes use of the function cifs_xquota_get, As
> an alternative the entire function cifs_xquota_get could be
> removed.
> ---
> Make use of cifs_xquota_get
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
> index fcc4342..339b829 100644
> --- a/fs/cifs/cifsfs.c
> +++ b/fs/cifs/cifsfs.c
> @@ -461,7 +461,7 @@ int cifs_xstate_get(struct super_block *sb, struct fs_quota_stat *qstats)
>
> static struct quotactl_ops cifs_quotactl_ops = {
> .set_xquota = cifs_xquota_set,
> - .get_xquota = cifs_xquota_set,
> + .get_xquota = cifs_xquota_get,
> .set_xstate = cifs_xstate_set,
> .get_xstate = cifs_xstate_get,
> };

Steve, this obvious bugfix seems to be stuck in cifs-2.6.git.

Can you forward this fix (and other fixes if you have any) to Linus soon?

TIA
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed




\
 
 \ /
  Last update: 2008-03-01 10:41    [W:0.181 / U:0.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site