[lkml]   [2008]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 3/4] Introduce pci_slot
    On Thu, Feb 28, 2008 at 05:28:55PM -0700, Alex Chiang wrote:
    > - Make pci_slot the primary sysfs entity. hotplug_slot becomes a
    > subsidiary structure.
    > o pci_create_slot() creates and registers a slot with the PCI core
    > o pci_slot_add_hotplug() gives it hotplug capability
    > - Change the prototype of pci_hp_register() to take the bus and
    > slot number (on parent bus) as parameters.
    > - Remove all the ->get_address methods since this functionality is
    > now handled by pci_slot directly.

    This describes what you did, but not why you are doing this, making it a
    pretty bad changelog comment.

    Can you refresh my memory as to the "why" for all of this and how you
    are handling machines that do not export this information at all?

    oh, and don't put "extern" in a .c file, and call kobject_uevent in the
    same function that you added the kobject in, unless there is a very good
    reason to do so, otherwise you just missed all of those events...


    greg k-h

     \ /
      Last update: 2008-03-01 06:25    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean