[lkml]   [2008]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 0/4, v7] PCI, ACPI: Physical PCI slot objects
    On Thu, Feb 28, 2008 at 05:23:41PM -0700, Alex Chiang wrote:
    > Hi Gary, John, Kenji-san, et. al,
    > Well, first Gary was on holiday for a month, and then I was on
    > holiday for a month, but I'm back now, and have refreshed this
    > patch series against 2.6.25.
    > The major thing that happened was all the kobject changes
    > (learned my lesson about taking long holidays when holding onto a
    > largish chunk of code that hasn't been accepted yet ;), and so
    > the only real change is in patch 3/4.
    > The kobject changes were nice, btw. In the prior versions of this
    > series, I could never figure out why my kobjects weren't getting
    > released when their refcounts went to 1, and had some hacky code
    > in there to manually release them. (I'm sure I was doing
    > something wrong, but I couldn't figure out what.) I was able to
    > remove that hack in this series because the kobjects are working
    > the way they're supposed to.
    > I did turn on kobject debugging, and all seems well except for
    > one little thing. I based my module (pci_slot) on acpiphp, and
    > the kobject system complains:
    > kobject: 'acpiphp' (a00000020476aed0): does not have a release()
    > function, it is broken and must be fixed.
    > kobject: 'pci_slot' (a000000204791e50): does not have a release()
    > function, it is broken and must be fixed.
    > Not quite sure what to do about these yet, but since no one has
    > fixed acpiphp yet, I'm thinking that I can't be *too* wrong. :)

    Um, the obvious solution of providing a release function for these
    kobjects is somehow not correct?

    Please do that, otherwise the code is wrong (and yes, acpiphp might be
    wrong as well, I haven't seen that report yet.)


    greg k-h

     \ /
      Last update: 2008-03-01 06:23    [W:0.026 / U:279.868 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site