Messages in this thread | | | Subject | Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7) | From | James Bottomley <> | Date | Fri, 08 Feb 2008 23:17:28 -0600 |
| |
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote: > +/* > + * Physical location of iSCSI Boot Format Table.
This is now the Virtual address, isn't it? So just drop the Physical.
> + */ > +unsigned long ibft_addr; > +EXPORT_SYMBOL(ibft_addr);
And since it is the virtual address, there's no point in keeping it unsigned long and doing all the casting. It should be struct ibft_table_hdr *, shouldn't it?
James
| |