lkml.org 
[lkml]   [2008]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [rft] s2ram wakeup moves to .c, could fix few machines
    Hi!

    > > Can you post a delta against my versoin? I do not see any changes from
    > > a quick glance.
    >
    > Appended (plus I removed two hunks, one in arch/x86/Makefile and one in
    > drivers/acpi/sleep/main.c that were unrelated to the rest of the patch).

    Thanks, applied.

    > > This is probably more acceptable version of beep; but there are
    > > probably even better ways to clean it...
    > >
    > > if (wakeup_header.realmode_flags & 4) {
    > > inb(97);
    > > outb(0, 0x80);
    > > outb(3, 97);
    > > outb(0, 0x80);
    > > outb(-74, 67);
    > > outb(0, 0x80);
    > > outb(-119, 66);
    > > outb(0, 0x80);
    > > outb(15, 66);
    > > }
    > >
    > > ...like the version that makes beep/pause/beep/pause, so that user can
    > > count them.
    >
    > Can we move it into a separate function?

    I guess we want to use HPA's morse code ;-).
    Pavel
    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


    \
     
     \ /
      Last update: 2008-02-08 22:15    [W:0.028 / U:63.056 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site