Messages in this thread | | | From | Frank Seidel <> | Subject | Re: [PATCH v2] mmc: extend ricoh_mmc to support Ricoh RL5c476 | Date | Thu, 7 Feb 2008 09:20:38 +0100 |
| |
Hi,
On Thursday 07 February 2008 09:08, Pierre Ossman wrote: > On Mon, 4 Feb 2008 19:25:42 +0100 > Frank Seidel <fseidel@suse.de> wrote: > > Signed-off-by: Frank Seidel <fseidel@suse.de> > > I see you've guys have kept yourself busy in my absence. :)
Yes, we really did :)
> As for the patch, it looks ok although I'm not really a fan of more > voodoo constants that noone knows what they mean. Could you add some > comments explaining some of them at least?
I also don't like that voodoo, but as long as we don't have more information or let alone specs.. well, i really wish i could provide more than the already IMHO obvious sequence.. voodoo-adress and value to make config bit writeable, set voodo-bit and cleanup again.
> > + if (fw_dev->device == PCI_DEVICE_ID_RICOH_RL5C476) { > > *snip* > > > + } else { > > + /* via R5C832 */ > > Wouldn't it be prudent to have a check that this is indeed a R5C832, > and a failure mode if it's none of the two known devices?
Also thought about that, but as far as i can see this cannot happen since we only probe for those two devices and deny to continue if anything else /those two were not found in the beginning.
Thanks, Frank
| |