lkml.org 
[lkml]   [2008]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: partition sysfs OOPS in current GIT
On Wed, Feb 06, 2008 at 11:11:44PM -0800, David Miller wrote:
> From: Greg KH <gregkh@suse.de>
> Date: Wed, 6 Feb 2008 23:00:44 -0800
>
> > On Wed, Feb 06, 2008 at 10:39:44PM -0800, David Miller wrote:
> > > From: Greg KH <gregkh@suse.de>
> > > Date: Wed, 6 Feb 2008 22:42:10 -0800
> > >
> > > > On Wed, Feb 06, 2008 at 10:05:44PM -0800, David Miller wrote:
> > > > > I found the problem, it's the "whole_disk" partition attribute.
> > > >
> > > > I don't understand that code at all, on 2.6.24, what does reading that
> > > > file give you? At first glance, I don't see how that file would spit
> > > > out anything and not give you the same kind of oops.
> > > >
> > > > you are in a maze of kobject pointers, all alike...
> > >
> > > It's supposed to just exist, and be an empty zero length file.
> > > That's why it's given no ->show method pointer.
> > >
> > > It's existence just means that the partition is a "whole disk"
> > > partition type.
> >
> > Can you try this patch to see if it solves the oops, and that the file
> > is still there and works properly?
>
> It doesn't crash, but the file returns -EIO instead of zero when read.

Picky, picky, picky :)

It's odd that the original one didn't also do that, but I'll fix that up
properly, let me try again...

thanks,

greg k-h


\
 
 \ /
  Last update: 2008-02-07 08:19    [from the cache]
©2003-2011 Jasper Spaans