Messages in this thread | | | Date | Thu, 7 Feb 2008 11:26:52 -0800 | From | Andrew Morton <> | Subject | Re: [git pull] CPU isolation extensions |
| |
On Thu, 07 Feb 2008 09:22:34 -0800 Max Krasnyansky <maxk@qualcomm.com> wrote:
> > - There are two separate and identical implementations of > > cpu_unusable(cpu). Please do it once, in a header, preferably with C > > function, not macros. > > Those are local versions that depend whether a feature is enabled or not. > If CONFIG_CPUISOL_WORKQUEUE is disabled we want to cpu_unusable() > in the workqueue.c to be a noop, and if it's enabled that macro resolve to > cpu_isolated(). > Same thing for the stopmachine.c. If CONFIG_CPUISOL_STOPMACHIN is disabled > cpu_unusable() is a noop. > In other words cpu_isolated() is the one common macro that subsystem may > want to stub out. > Do you see another way of doing this ?
ah, I missed that. Yup, the implementation you have there looks OK.
| |