lkml.org 
[lkml]   [2008]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFT 6/9] Char: moxa, remove useless tty functions
    Date
    - moxa_flush_chars -- no code; ldics handle this well
    - moxa_put_char -- only wrapper to moxa_write (same code), tty does this
    the same way if tty->driver->put_char is NULL

    Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
    ---
    drivers/char/moxa.c | 25 -------------------------
    1 files changed, 0 insertions(+), 25 deletions(-)

    diff --git a/drivers/char/moxa.c b/drivers/char/moxa.c
    index d123827..5f7fb38 100644
    --- a/drivers/char/moxa.c
    +++ b/drivers/char/moxa.c
    @@ -193,8 +193,6 @@ static int moxa_write(struct tty_struct *, const unsigned char *, int);
    static int moxa_write_room(struct tty_struct *);
    static void moxa_flush_buffer(struct tty_struct *);
    static int moxa_chars_in_buffer(struct tty_struct *);
    -static void moxa_flush_chars(struct tty_struct *);
    -static void moxa_put_char(struct tty_struct *, unsigned char);
    static void moxa_throttle(struct tty_struct *);
    static void moxa_unthrottle(struct tty_struct *);
    static void moxa_set_termios(struct tty_struct *, struct ktermios *);
    @@ -372,8 +370,6 @@ static const struct tty_operations moxa_ops = {
    .write_room = moxa_write_room,
    .flush_buffer = moxa_flush_buffer,
    .chars_in_buffer = moxa_chars_in_buffer,
    - .flush_chars = moxa_flush_chars,
    - .put_char = moxa_put_char,
    .ioctl = moxa_ioctl,
    .throttle = moxa_throttle,
    .unthrottle = moxa_unthrottle,
    @@ -1258,27 +1254,6 @@ static int moxa_chars_in_buffer(struct tty_struct *tty)
    return chars;
    }

    -static void moxa_flush_chars(struct tty_struct *tty)
    -{
    - /*
    - * Don't think I need this, because this is called to empty the TX
    - * buffer for the 16450, 16550, etc.
    - */
    -}
    -
    -static void moxa_put_char(struct tty_struct *tty, unsigned char c)
    -{
    - struct moxa_port *ch = tty->driver_data;
    -
    - if (ch == NULL)
    - return;
    - spin_lock_bh(&moxa_lock);
    - MoxaPortWriteData(ch, &c, 1);
    - spin_unlock_bh(&moxa_lock);
    -
    - ch->statusflags |= LOWWAIT;
    -}
    -
    static int moxa_tiocmget(struct tty_struct *tty, struct file *file)
    {
    struct moxa_port *ch = tty->driver_data;
    --
    1.5.3.8


    \
     
     \ /
      Last update: 2008-02-07 20:19    [W:0.076 / U:29.676 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site