lkml.org 
[lkml]   [2008]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] palm_bk3710: factor out cable detection
    On Feb 7, 2008 3:41 PM, Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
    > Bartlomiej Zolnierkiewicz wrote:
    >
    > > Factor out cable detection to palm_bk3710_cable_detect().
    >
    > > Cc: Anton Salnikov <asalnikov@ru.mvista.com>
    > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    >
    > > Index: b/drivers/ide/arm/palm_bk3710.c
    > > ===================================================================
    > > --- a/drivers/ide/arm/palm_bk3710.c
    > > +++ b/drivers/ide/arm/palm_bk3710.c
    > > @@ -311,6 +311,12 @@ static void __devinit palm_bk3710_chipin
    > > palm_bk3710_setpiomode(base, NULL, 0, 600, 0);
    > > palm_bk3710_setpiomode(base, NULL, 1, 600, 0);
    > > }
    > > +
    > > +static u8 __devinit palm_bk3710_cable_detect(ide_hwif_t *hwif)
    > > +{
    > > + return ATA_CBL_PATA80;
    > > +}
    > > +
    > > static int __devinit palm_bk3710_probe(struct platform_device *pdev)
    > > {
    > > struct clk *clkp;
    > > @@ -381,7 +387,7 @@ static int __devinit palm_bk3710_probe(s
    > > hwif->set_dma_mode = &palm_bk3710_set_dma_mode;
    > > hwif->mmio = 1;
    > > default_hwif_mmiops(hwif);
    > > - hwif->cbl = ATA_CBL_PATA80;
    > > + hwif->cbl = palm_bk3710_cable_detect(hwif);
    > > hwif->ultra_mask = 0x1f; /* Ultra DMA Mode 4 Max
    > > (input clk 99MHz) */
    > > hwif->mwdma_mask = 0x7;
    >
    > Hm, how does it help if you don't make it into driver's method? :-O

    This was meant to be a preparation before converting palm_bk3710 to
    use struct ide_port_info. On the second thought this change may be as
    well integrated into the future patch (which I'll try to cook later
    today, unless somebody beats me to it ;-).

    Thanks,
    Bart


    \
     
     \ /
      Last update: 2008-02-07 17:17    [W:0.023 / U:30.600 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site