Messages in this thread | | | Date | Thu, 07 Feb 2008 15:55:59 +0300 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 2/5] ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc() |
| |
Bartlomiej Zolnierkiewicz wrote:
>>>Same BUG_ON() is present inside ide_set_handler().
>> There is no BUG_ON there -- __ide_set_handler() has a check for the same >>condition and a printk(KERN_CRIT)... myabe it should be replaced with BUG_ON()...
> Yeah, you're right - care to make a patch?
Replacing printk() with BUG_ON() and also removing BUG_ON() from ide_execute_command()? OK, will do...
>>>Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>>Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
| |