lkml.org 
[lkml]   [2008]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 21/73] CONNECTOR: Dont touch queue dev after decrement of ref count.
    2.6.23-stable review patch.  If anyone has any objections, please let us know.
    ------------------
    From: Li Zefan <lizf@cn.fujitsu.com>

    [CONNECTOR]: Don't touch queue dev after decrement of ref count.

    [ Upstream commit: cf585ae8ae9ac7287a6d078425ea32f22bf7f1f7 ]

    cn_queue_free_callback() will touch 'dev'(i.e. cbq->pdev), so it
    should be called before atomic_dec(&dev->refcnt).

    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/connector/cn_queue.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/connector/cn_queue.c
    +++ b/drivers/connector/cn_queue.c
    @@ -99,8 +99,8 @@ int cn_queue_add_callback(struct cn_queu
    spin_unlock_bh(&dev->queue_lock);

    if (found) {
    - atomic_dec(&dev->refcnt);
    cn_queue_free_callback(cbq);
    + atomic_dec(&dev->refcnt);
    return -EINVAL;
    }

    --


    \
     
     \ /
      Last update: 2008-02-07 01:07    [W:0.019 / U:30.928 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site