Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH] [1/2] Move NUMAQ io handling into arch/x86/pci/numa.c | Date | Wed, 6 Feb 2008 09:15:00 +0100 |
| |
> > +#define XQUAD_PORTIO_BASE 0xfe400000 > > There is still a definition in include/asm-x86/io_32.h . Is this > intentional?
Probably not.
> > > +extern void *xquad_portio; /* Where the IO area was mapped */ > > Does the extern need to be here when you've added it (minus the comment) > to mach_apic.h later in the patch?
The extern was intended to be removed, but somehow that change didn't make it into the final patch. Doesn't matter much either way though.
> Fix for "x86: move NUMAQ io handling into arch/x86/pci/numa.c" > > The intention of commit c7e844f0415252c7e1a2153a97e7a0c511d61ada was to > replace a number of outl_quad() calls with a writel() equivilant. One of > the changes was not equivilant. This patch corrects it.
Yes looks good; thanks.
-Andi
| |