lkml.org 
[lkml]   [2008]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH for review] ACPI: Create /sys/firmware/acpi/interrupts/ counters
    On Tue, Feb 05, 2008 at 02:30:10AM -0500, Len Brown wrote:
    > # cat /sys/firmware/acpi/interrupts/summary
    > pm_timer 0
    > glbl_lock 0
    > power_btn 0
    > sleep_btn 0
    > rtc 0
    > gpe00 0
    > gpe01 0
    > gpe02 0
    > gpe03 0
    > gpe04 0
    > gpe05 0
    > gpe06 0
    > gpe07 0
    > gpe08 0
    > gpe09 2
    > gpe0A 0
    > gpe0B 0
    > gpe0C 0
    > gpe0D 0
    > gpe0E 0
    > gpe0F 0
    > gpe10 0
    > gpe11 60
    > gpe12 0
    > gpe13 0
    > gpe14 0
    > gpe15 0
    > gpe16 0
    > gpe17 0
    > gpe18 0
    > gpe19 1
    > gpe1A 0
    > gpe1B 0
    > gpe1C 0
    > gpe1D 0
    > gpe1E 0
    > gpe1F 0
    > gpe_hi 0
    > gpe_total 63
    > acpi_irq 63

    Eeek! Why? What's wrong with individual files here? What's to ensure
    that you aren't going to overflow your buffer? There's a reason we
    don't have the seq file interface for sysfs, to prevent this very kind
    of thing...


    > + /*
    > + * General Purpose Events
    > + */
    > + for (i = 0; i < number_of_gpes; i++) {
    > + count += sprintf(buf + count, "gpe%02X %4d\n",
    > + i, acpi_gpe_counters[i]);
    > + }

    Nope, no error checking, fun chance of blowing the memory buffer :(

    Please change the interface to not do this.

    Oh, and for every new sysfs file, you need a Documentation/ABI/
    addition, please also add that.

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2008-02-05 23:23    [W:0.023 / U:29.600 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site