Messages in this thread | | | Date | Tue, 05 Feb 2008 12:12:38 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [git pull] x86 updates |
| |
Linus Torvalds wrote: > > Ingo, Thomas, > should we not do this? > > Otherwise, it seems we generate a section that isn't allocated? > > I think toolchain should add the right flags automatically for sections > that start with ".[ro]data" and ".text", but not for the kernel-specific > ".init.*" sections. > > Linus > > --- > arch/x86/kernel/head_64.S | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kernel/head_64.S b/arch/x86/kernel/head_64.S > index 4f283ad..d16d7b8 100644 > --- a/arch/x86/kernel/head_64.S > +++ b/arch/x86/kernel/head_64.S > @@ -251,7 +251,7 @@ ENTRY(secondary_startup_64) > > /* SMP bootup changes these two */ > #ifndef CONFIG_HOTPLUG_CPU > - .pushsection .init.data > + .pushsection .init.data,"aw" > #endif > .align 8 > .globl initial_code
I definitely think we should add flags where applicable.
-hpa
| |