Messages in this thread | | | Date | Tue, 05 Feb 2008 13:20:59 -0500 | From | Jeff Garzik <> | Subject | Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23) |
| |
akpm@linux-foundation.org wrote: > From: Michael Pyne <michael.pyne@kdemail.net> > > Partially revert a change to mac address detection introduced to the forcedeth > driver. The change was intended to correct mac address detection for newer > nVidia chipsets where the mac address was stored in reverse order. One of > those chipsets appears to still have the mac address in reverse order (or at > least, it does on my system). > > The change that broke mac address detection for my card was commit > ef756b3e56c68a4d76d9d7b9a73fa8f4f739180f "forcedeth: mac address correct" > > My network card is an nVidia built-in Ethernet card, output from lspci as > follows (with text and numeric ids): > $ lspci | grep Ethernet > 00:07.0 Bridge: nVidia Corporation MCP61 Ethernet (rev a2) > $ lspci -n | grep 07.0 > 00:07.0 0680: 10de:03ef (rev a2) > > The vendor id is, of course, nVidia. The device id corresponds to the > NVIDIA_NVENET_19 entry. > > The included patch fixes the MAC address detection on my system. > Interestingly, the MAC address appears to be in the range reserved for my > motherboard manufacturer (Gigabyte) and not nVidia. > > Signed-off-by: Michael J. Pyne <michael.pyne@kdemail.net> > Cc: Jeff Garzik <jeff@garzik.org> > Cc: Ayaz Abdulla <aabdulla@nvidia.com> > Cc: <stable@kernel.org> > > On Wed, 21 Nov 2007 15:34:52 -0800 > "Ayaz Abdulla" <AAbdulla@nvidia.com> wrote: > >> The solution is to get the OEM to update their BIOS (instead of >> integrating this patch) since the MCP61 specs indicate that the MAC >> Address should be in correct order from BIOS. >> >> By changing the feature DEV_HAS_CORRECT_MACADDR to all MCP61 boards, it >> could cause it to break on other OEM systems who have implemented it >> correctly. >> > > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
NAK - this fixes one set of users, and breaks a working set of users.
Need to add DMI check for the specific motherboard (dmi_check_system), and flip flag according to success/failure of that check.
Jeff
| |