Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] Whine about suspicious return values from module's ->init() hook | Date | Tue, 5 Feb 2008 17:08:37 +1100 |
| |
On Tuesday 05 February 2008 14:53:18 Andrew Morton wrote: > On Tue, 5 Feb 2008 14:43:31 +1100 Rusty Russell <rusty@rustcorp.com.au> wrote: > > On Tuesday 05 February 2008 02:42:15 Alexey Dobriyan wrote: > > > One head-scratching session could be noticeably shorter with this > > > patch... > > > > > > Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru> > > > > If we want to prevent > 0 returns, let's just BUG_ON(). > > That risks killing previously-working setups. WARN_ON is sufficient.
I disagree. WARN_ON is useful for developers, but they can handle BUG_ON, too.
If we were in freeze, I'd say WARN_ON.
Even better, audit them all, then BUG_ON. Alexey? Rusty.
| |