Messages in this thread | | | Date | Mon, 4 Feb 2008 15:51:09 -0800 | From | Andrew Morton <> | Subject | Re: CodingStyle: provide good example |
| |
On Tue, 5 Feb 2008 00:43:43 +0100 Pavel Machek <pavel@ucw.cz> wrote:
> if (!buffer) is actually prefered style, so lets use it in example. > > Pavel > > Signed-off-by: Pavel Machek <pavel@suse.cz> > > diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle > index 6caa146..9bb2d8a 100644 > --- a/Documentation/CodingStyle > +++ b/Documentation/CodingStyle > @@ -406,7 +415,7 @@ int fun(int a) > int result = 0; > char *buffer = kmalloc(SIZE); > > - if (buffer == NULL) > + if (!buffer) > return -ENOMEM; > > if (condition1) {
I tend to avoid preferring one over the other unless the extra seven columns is needed to prevent wraparound nasties.
| |