Messages in this thread | | | Date | Mon, 04 Feb 2008 22:59:21 +0100 | From | Roel kluin <> | Subject | [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test 'if (level & TP_EC_FAN_FULLSPEED)' |
| |
in drivers/misc/thinkpad_acpi.c, lines 4137-4142 it reads:
/* safety net should the EC not support AUTO * or FULLSPEED mode bits and just ignore them */ if (level & TP_EC_FAN_FULLSPEED) level |= 7; /* safety min speed 7 */ else if (level & TP_EC_FAN_FULLSPEED) level |= 4; /* safety min speed 4 */
note the nonsense duplicate test 'if (level & TP_EC_FAN_FULLSPEED)'. should this be changed to:
if (level & TP_EC_FAN_FULLSPEED) level |= 7; /* safety min speed 7 */ else level |= 4; /* safety min speed 4 */
or maybe
if (level & TP_EC_FAN_FULLSPEED) level |= 7; /* safety min speed 7 */ if (level & TP_EC_FAN_FULLSPEED) level |= 4; /* safety min speed 4 */
?
| |