lkml.org 
[lkml]   [2008]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86: vmlinux_64.lds.S - use THREAD_SIZE instead of numeric constant
    Hi Cyrill.
    On Mon, Feb 04, 2008 at 08:10:37PM +0300, Cyrill Gorcunov wrote:
    > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>

    The patch looks simple but please explain why you do what you do.
    It took me some digging before I could convince mysleft this was
    indeed a correct change.
    And I am pretty sure you did the same investigation yourself.

    A comment like:

    arch/x866/kernel/inittask.c require all variables allocated in
    the section .data.init_task to be aligned with THREAD_SIZE.

    would have made me happy.

    Sam

    > ---
    >
    > Index: linux-2.6.git/arch/x86/kernel/vmlinux_64.lds.S
    > ===================================================================
    > --- linux-2.6.git.orig/arch/x86/kernel/vmlinux_64.lds.S 2008-01-30 17:51:57.000000000 +0300
    > +++ linux-2.6.git/arch/x86/kernel/vmlinux_64.lds.S 2008-02-03 22:38:48.000000000 +0300
    > @@ -129,7 +129,7 @@ SECTIONS
    > #undef VVIRT_OFFSET
    > #undef VVIRT
    >
    > - . = ALIGN(8192); /* init_task */
    > + . = ALIGN(THREAD_SIZE); /* init_task */
    > .data.init_task : AT(ADDR(.data.init_task) - LOAD_OFFSET) {
    > *(.data.init_task)
    > }:data.init


    \
     
     \ /
      Last update: 2008-02-04 21:25    [W:0.054 / U:90.364 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site