Messages in this thread | | | Date | Sun, 3 Feb 2008 23:28:55 +0530 | From | Rabin Vincent <> | Subject | Re: [PATCH] Remove unneeded code in sys_getpriority |
| |
On Sun, Feb 03, 2008 at 10:54:45AM +0100, Frank Seidel wrote: > On Sunday 03 February 2008 04:04, Rabin Vincent wrote: > > This check is not required because the condition is always true. > > ... > > - if (niceval > retval) > > - retval = niceval; > > + retval = 20 - task_nice(p); > > Thats surely correct, but on the other hand currently those > case blocks are quite independet of their possition/could easily > be rearranged now .. or think of another case is put ahead. > Then this could mess up things.
Do you mean the PRIO_* cases in the switch? They're still independent of position after the patch because they don't fall through.
> Thanks, > Frank
Rabin
| |