lkml.org 
[lkml]   [2008]   [Feb]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/9] drivers/acpi/asus_acpi.c: Correct use of ! and &
On Thu, Feb 28, 2008 at 09:55:03PM -0800, Andrew Morton wrote:
> if (invert) /* invert target value */
> - led_out = !led_out & 0x1;
> + led_out = !led_out;
>
> if (!write_acpi_int(hotk->handle, ledname, led_out, NULL))

But now you're writing 0xffffffff instead of 1. I think the suggestion
of led_out ^= 1 was the correct one.

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."


\
 
 \ /
  Last update: 2008-02-29 07:13    [W:0.080 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site