Messages in this thread | | | Subject | Re: [patch 14/21] scan noreclaim list for reclaimable pages | From | Lee Schermerhorn <> | Date | Fri, 29 Feb 2008 09:38:54 -0500 |
| |
On Thu, 2008-02-28 at 15:41 -0800, Randy Dunlap wrote: > On Thu, 28 Feb 2008 14:29:22 -0500 Rik van Riel wrote: > > > V2 -> V3: > > + rebase to 23-mm1 atop RvR's split LRU series > > > > New in V2 > > > > This patch adds a function to scan individual or all zones' noreclaim > > lists and move any pages that have become reclaimable onto the respective > > zone's inactive list, where shrink_inactive_list() will deal with them. > > > > This replaces the function to splice the entire noreclaim list onto the > > active list for rescan by shrink_active_list(). That method had problems > > with vmstat accounting and complicated '[__]isolate_lru_pages()'. Now, > > __isolate_lru_page() will never isolate a non-reclaimable page. The > > only time it should see one is when scanning nearby pages for lumpy > > reclaim. > > > > TODO: This approach may still need some refinement. > > E.g., put back to active list? > > > > DEBUGGING ONLY: NOT FOR UPSTREAM MERGE > > > > Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com> > > Signed-off-by: Rik van Riel <riel@redhat.com> > > > Hi, > > I haven't looked at all 21 patches, but please use kernel-doc > notation as it's defined. See Documentation/kernel-doc-nano-HOWTO.txt > for details, or ask.
Hi, Randy:
I'll make a pass thru the noreclaim patches and fix up the comment blocks that are not quite kernel-doc. I have to update some of the patch descriptions as well, as some have become stale thanks to additional work by Kosaki-san [e.g., the page vec cleanup].
I'll discuss with Rik, off-list, how to coordinate for the next reposting.
Thanks, Lee
| |