lkml.org 
[lkml]   [2008]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/11] VFS: Add security label support to *notify
    On Wed, Feb 27, 2008 at 05:11:26PM -0500, David P. Quigley wrote:
    > This patch adds two new fields to the iattr structure. The first field holds a
    > security label while the second contains the length of this label. In addition
    > the patch adds a new helper function inode_setsecurity which calls the LSM to
    > set the security label on the inode. Finally the patch modifies the necessary
    > functions such that fsnotify_change can handle notification requests for
    > dnotify and inotify.

    Please don't overload setattr with this. Just looking at your callers
    shows that it's much cleaner as a separate method.

    Now what's really lacking is a desciption _why_ you actually need it
    to start with. The current method to set security labels is through
    the security.* xattrs. Now if we want to clean up that somewhat
    messy method that might be a good idea, but we should do it for all
    callers and not just some.

    > +#define DN_LABEL 0x00000040 /* File (re)labeled */

    An any inotify/dnotify additions should be separate from the vfs to
    filesystem interface. Please make it a separate patch and describe
    properly why it's needed in it's description.

    > index df6b95d..1169963 100644
    > --- a/include/linux/xattr.h
    > +++ b/include/linux/xattr.h
    > @@ -50,6 +50,7 @@ ssize_t xattr_getsecurity(struct inode *, const char *, void *, size_t);
    > ssize_t vfs_getxattr(struct dentry *, char *, void *, size_t);
    > ssize_t vfs_listxattr(struct dentry *d, char *list, size_t size);
    > int vfs_setxattr(struct dentry *, char *, void *, size_t, int);
    > +int vfs_setxattr_locked(struct dentry *, char *, void *, size_t, int);
    > int vfs_removexattr(struct dentry *, char *);
    >
    > ssize_t generic_getxattr(struct dentry *dentry, const char *name, void *buffer, size_t size);
    > --
    > 1.5.3.8
    >
    > -
    > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    ---end quoted text---


    \
     
     \ /
      Last update: 2008-02-29 00:57    [W:4.554 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site