lkml.org 
[lkml]   [2008]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] i2c-amd756.c: fix off-by-one
Hi Adrian,

On Wed, 27 Feb 2008 23:21:09 +0200, Adrian Bunk wrote:
> This patch fixes an off-by-one error spotted by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
> f9829dd0d7dad9cbc08da3fceb105478e85c4137 foobar
> diff --git a/drivers/i2c/busses/i2c-amd756.c b/drivers/i2c/busses/i2c-amd756.c
> index 573abe4..2fa4318 100644
> --- a/drivers/i2c/busses/i2c-amd756.c
> +++ b/drivers/i2c/busses/i2c-amd756.c
> @@ -335,7 +335,7 @@ static int __devinit amd756_probe(struct pci_dev *pdev,
> u8 temp;
>
> /* driver_data might come from user-space, so check it */
> - if (id->driver_data > ARRAY_SIZE(chipname))
> + if (id->driver_data >= ARRAY_SIZE(chipname))
> return -EINVAL;
>
> if (amd756_ioport) {
>

Good catch, not sure how I managed to mess it up that way. Patch
applied, thank you.

--
Jean Delvare


\
 
 \ /
  Last update: 2008-02-28 21:09    [W:0.087 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site