Messages in this thread | | | Date | Thu, 28 Feb 2008 12:08:45 +0100 | From | Takashi Iwai <> | Subject | Re: [PATCH 10/12] sound: au88x0_pcm.c fix integer as NULL pointer warning |
| |
At Wed, 27 Feb 2008 16:56:08 -0800, Harvey Harrison wrote: > > sound/pci/au88x0/au88x0_pcm.c:508:15: warning: Using plain integer as NULL pointer > > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> > --- > sound/pci/au88x0/au88x0_pcm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/pci/au88x0/au88x0_pcm.c b/sound/pci/au88x0/au88x0_pcm.c > index 526c6c5..232eb80 100644 > --- a/sound/pci/au88x0/au88x0_pcm.c > +++ b/sound/pci/au88x0/au88x0_pcm.c > @@ -505,7 +505,7 @@ static int __devinit snd_vortex_new_pcm(vortex_t * chip, int idx, int nr) > int i; > int err, nr_capt; > > - if ((chip == 0) || (idx < 0) || (idx >= VORTEX_PCM_LAST)) > + if ((chip == NULL) || (idx < 0) || (idx >= VORTEX_PCM_LAST))
"if (!chip)" is the standard style. Let's fix in that way. Also, strip unneeded parentheses.
thanks,
Takashi
| |