Messages in this thread | | | Date | Wed, 27 Feb 2008 10:43:32 +0200 (EET) | From | Pekka J Enberg <> | Subject | Re: [PATCH 00/28] Swap over NFS -v16 |
| |
On Wed, 27 Feb 2008, Peter Zijlstra wrote: > Humm, and here I sit staring at the screen. Perhaps I should go get my > morning juice, but... > > if (mem_reserve_kmalloc_charge(my_res, sizeof(*foo), 0)) { > foo = kmalloc(sizeof(*foo), gfp|__GFP_MEMALLOC) > if (!kmem_is_emergency(foo)) > mem_reserve_kmalloc_charge(my_res, -sizeof(*foo), 0) > } else > foo = kmalloc(sizeof(*foo), gfp); > > Just doesn't look too pretty.. > > And needing to always account the allocation seems wrong.. but I'll take > poison and see if that wakes up my mind.
Hmm, perhaps this is just hand-waving but why don't you have a kmalloc_reserve() function in SLUB that does the accounting properly?
Pekka
| |