lkml.org 
[lkml]   [2008]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] gxfb: Replace FBSIZE config option with a kernel argument
On Sat, 23 Feb 2008 01:10:45 -0500
Andres Salomon <dilinger@queued.net> wrote:

> @@ -425,7 +424,10 @@ static int __init gxfb_setup(char *options)
> if (!*opt)
> continue;
>
> - mode_option = opt;
> + if (!strncmp(opt, "fbsize:", 7))
> + fbsize = simple_strtoul(opt+7, NULL, 0);
> + else
> + mode_option = opt;
> }

The above shouldn't be necessary.

And it should have been documented in Documentation/kernel-parameters.txt.

And "fbsize=N" would be a lot more conventional than "fbsize:N"

I suspect that the formulation you have here will not permit "fbsize:128k",
whereas "fbsize=128k" or "gxfb.fbsize=128k" should work. Needs checking.

> return 0;
> @@ -456,5 +458,8 @@ module_exit(gxfb_cleanup);
> module_param(mode_option, charp, 0);
> MODULE_PARM_DESC(mode_option, "video mode (<x>x<y>[-<bpp>][@<refr>])");
>
> +module_param(fbsize, int, 0);
> +MODULE_PARM_DESC(fbsize, "video memory size");
> +

Because the module_param() already makes fbsize available on the kernel
boot command line via gxfb.fbsize=42 (or something similar).




\
 
 \ /
  Last update: 2008-02-28 01:35    [W:0.073 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site