lkml.org 
[lkml]   [2008]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] alloc_percpu() fails to allocate percpu data
On Sat, 23 Feb 2008, Nick Piggin wrote:

> What I don't understand is why the slab allocators have something like
> this in it:
>
> if ((flags & SLAB_HWCACHE_ALIGN) &&
> size > cache_line_size() / 2)
> return max_t(unsigned long, align, cache_line_size());
>
> If you ask for HWCACHE_ALIGN, then you should get it. I don't
> understand, why do they think they knows better than the caller?

Tradition.... Its irks me as well.

> Things like this are just going to lead to very difficult to track
> performance problems. Possibly correctness problems in rare cases.
>
> There could be another flag for "maybe align".

SLAB_HWCACHE_ALIGN *is* effectively a maybe align flag given the above
code.

If we all agree then we could change this to have must have semantics? It
has the potential of enlarging objects for small caches.

SLAB_HWCACHE_ALIGN has an effect that varies according to the alignment
requirements of the architecture that the kernel is build on. We may be in
for some surprises if we change this.



\
 
 \ /
  Last update: 2008-02-27 20:47    [W:1.718 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site