Messages in this thread | | | Date | Wed, 27 Feb 2008 18:45:35 +0200 | Subject | Re: [PATCH -mm 1/4] LSM: Introduce inode_getsecid and ipc_getsecid hooks | From | "Ahmed S. Darwish" <> |
| |
Hi Paul,
On Wed, Feb 27, 2008 at 11:04:57AM -0500, Paul Moore wrote: > On Tuesday 26 February 2008 6:24:11 pm Ahmed S. Darwish wrote: > > Introduce inode_getsecid(inode, secid) and ipc_getsecid(ipcp, secid) > > LSM hooks. > > > > This hooks will be used instead of similar exported SELinux > > interfaces. > > > > Signed-off-by: Casey Schaufler <casey@schaufler-ca.com> > > Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com> > > --- > > > > include/linux/security.h | 18 ++++++++++++++++++ > > security/dummy.c | 12 ++++++++++++ > > security/security.c | 12 ++++++++++++ > > 3 files changed, 42 insertions(+) > > ... > ... > > > +static inline void security_ipc_getsecid(struct kern_ipc_perm *ipcp, > > u32 *secid) > > +{ } > > Should these both do a "*secid = 0;"? >
Yes, this will also lead to consistency in the interface espcially after changing task_getsecid to do the same (in patch #3).
> > diff --git a/security/dummy.c b/security/dummy.c > > index 6a0056b..c2f4c52 100644 > > --- a/security/dummy.c > > +++ b/security/dummy.c > > @@ -422,6 +422,11 @@ static int dummy_inode_listsecurity(struct inode > > *inode, char *buffer, size_t bu return 0; > > } > > > > +static void dummy_inode_getsecid(const struct inode *inode, u32 > > *secid) > > +{ > > + return; > > +} > > ... > > > +static void dummy_ipc_getsecid(struct kern_ipc_perm *ipcp, u32 > > *secid) > > +{ > > + return; > > +} > > Same question. >
Both will be changed to *secid = 0 in the comming send. Thanks!
--
"Better to light a candle, than curse the darkness"
Ahmed S. Darwish Homepage: http://darwish.07.googlepages.com Blog: http://darwish-07.blogspot.com
| |