Messages in this thread | | | Date | Wed, 27 Feb 2008 13:26:47 +0900 | From | KOSAKI Motohiro <> | Subject | Re: [RFC][PATCH] page reclaim throttle take2 |
| |
Hi Peter,
> > + > > + atomic_t nr_reclaimers; > > + wait_queue_head_t reclaim_throttle_waitq; > > /* > > * rarely used fields: > > */ > > Small nit, that extra blank line seems at the wrong end of the text > block :-)
Agghhh, sorry ;-) I'll fix at next post.
> > +out: > > + atomic_dec(&zone->nr_reclaimers); > > + wake_up_all(&zone->reclaim_throttle_waitq); > > + > > + return ret; > > +} > > Would it be possible - and worthwhile - to make this FIFO fair?
Hmmm may be, we don't need perfectly fair. because try_to_free_page() is unfair mechanism.
but I will test use wake_up() instead wake_up_all(). it makes so so fair order if no performance regression happend.
Thanks very useful comment.
- kosaki
| |