lkml.org 
[lkml]   [2008]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] page reclaim throttle take2
Hi Peter,

> > +
> > + atomic_t nr_reclaimers;
> > + wait_queue_head_t reclaim_throttle_waitq;
> > /*
> > * rarely used fields:
> > */
>
> Small nit, that extra blank line seems at the wrong end of the text
> block :-)

Agghhh, sorry ;-)
I'll fix at next post.

> > +out:
> > + atomic_dec(&zone->nr_reclaimers);
> > + wake_up_all(&zone->reclaim_throttle_waitq);
> > +
> > + return ret;
> > +}
>
> Would it be possible - and worthwhile - to make this FIFO fair?

Hmmm
may be, we don't need perfectly fair.
because try_to_free_page() is unfair mechanism.

but I will test use wake_up() instead wake_up_all().
it makes so so fair order if no performance regression happend.

Thanks very useful comment.


- kosaki





\
 
 \ /
  Last update: 2008-02-27 05:33    [W:0.080 / U:0.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site