Messages in this thread | | | Date | Tue, 26 Feb 2008 23:46:53 +0030 | From | "Paolo Ciarrocchi" <> | Subject | Re: [PATCH] ide-cd: fix some codestyle and most of the checkpatch.pl issues |
| |
On 2/26/08, Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > > On Tuesday 26 February 2008, Borislav Petkov wrote: > > Signed-off-by: Borislav Petkov <petkovbb@gmail.com> > > --- > > drivers/ide/ide-cd.c | 634 > +++++++++++++++++++++++++------------------------ > > 1 files changed, 323 insertions(+), 311 deletions(-) > > With 300 lines changed this is not trivial to review/apply anymore > (yeah, I sound like a broken record ;-) and since I've already applied > Paolo's patch from two days ago this one heavily rejects... > > Moreover md5sum is different before/after the patch - I tried really hard > to figure out why (by reverting some changes) but finally I gave up.
is it because of the changes in the include section? and was the change suggested by checkpatch.pl?
ciao, -- Paolo http://paolo.ciarrocchi.googlepages.com/
| |