Messages in this thread | | | Date | Mon, 25 Feb 2008 23:33:37 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] x86_64: remove wrong setting about CONSTANT_TSC for intel cpu |
| |
Yinghai Lu wrote: >> which is the same. set_cpu_cap() is indeed the cleaner form to do this >> so your patch is correct as a cleanup. > set_cpu_cap is right > == > set_bit(X86_FEATURE_CONSTANT_TSC, &c->x86_capability); ===> is wrong > should be > set_bit(X86_FEATURE_CONSTANT_TSC, c->x86_capability); > > x86_capability is a array ... >
For an array, the & is optional and has no effect.
So they mean the same thing.
-hpa
| |